This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2475089 Fix maven options (#7105)
2475089 is described below
commit 24750891e42641fa49a6c5f018318d7ffc7b6be6
Author: Subbu Subramaniam <[email protected]>
AuthorDate: Tue Jun 29 17:22:12 2021 -0700
Fix maven options (#7105)
* Fix maven options
For some reason, MAVEN_OPTS seems to be triggering a build failure when
exported as an option. Changing the variable to PINOT_MAVEN_OPTS seems
to work.
* Fixed a typo
---
compatibility-verifier/checkoutAndBuild.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/compatibility-verifier/checkoutAndBuild.sh
b/compatibility-verifier/checkoutAndBuild.sh
index bc79422..f624cea 100755
--- a/compatibility-verifier/checkoutAndBuild.sh
+++ b/compatibility-verifier/checkoutAndBuild.sh
@@ -36,7 +36,7 @@ function usage() {
echo -e " To compare this checkout with some older tag or hash:
'${cmdName} -o release-0.7.1 -w /tmp/wd'"
echo -e " To compare any two previous tags or hashes: '${cmdName} -o
release-0.7.1 -n 637cc3494 -w /tmp/wd"
echo -e "Environment:"
- echo -e " Additional maven build options can be passed in via environment
varibale MAVEN_OPTS"
+ echo -e " Additional maven build options can be passed in via environment
variable PINOT_MAVEN_OPTS"
exit 1
}
@@ -52,7 +52,7 @@ function checkoutAndBuild() {
# Pull the tag list so that we can check out by tag name
git fetch --tags || exit 1
git checkout $commitHash || exit 1
- mvn install package -DskipTests -Pbin-dist -T 4 -Djdk.version=8
${MAVEN_OPTS} || exit 1
+ mvn install package -DskipTests -Pbin-dist -T 4 -Djdk.version=8
${PINOT_MAVEN_OPTS} || exit 1
popd || exit 1
exit 0
}
@@ -119,7 +119,7 @@ workingDir=$(absPath "$workingDir")
newTargetDir="$workingDir"/newTargetDir
if [ -z "$newerCommit" ]; then
echo "Compiling current tree as newer version"
- (cd $cmdDir/.. && mvn install package -DskipTests -Pbin-dist -T 4 -D
jdk.version=8 ${MAVEN_OPTS} && mvn -pl pinot-tools package -T 4 -DskipTests
-Djdk.version=8 ${MAVEN_OPTS} && mvn -pl pinot-integration-tests package -T 4
-DskipTests -Djdk.version=8 ${MAVEN_OPTS})
+ (cd $cmdDir/.. && mvn install package -DskipTests -Pbin-dist -T 4 -D
jdk.version=8 ${PINOT_MAVEN_OPTS} && mvn -pl pinot-tools package -T 4
-DskipTests -Djdk.version=8 ${PINOT_MAVEN_OPTS} && mvn -pl
pinot-integration-tests package -T 4 -DskipTests -Djdk.version=8
${PINOT_MAVEN_OPTS})
if [ $? -ne 0 ]; then
echo Compile failed.
exit 1
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
