KKcorps commented on a change in pull request #7140:
URL: https://github.com/apache/incubator-pinot/pull/7140#discussion_r665948443
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/RealtimeKinesisIntegrationTest.java
##########
@@ -208,15 +221,11 @@ public void startKinesis()
throws Exception {
try {
final LocalstackDockerConfiguration dockerConfig =
PROCESSOR.process(this.getClass());
- localstackDocker.startup(dockerConfig);
- } catch (LocalstackDockerException e) {
StopAllLocalstackDockerCommand stopAllLocalstackDockerCommand = new
StopAllLocalstackDockerCommand();
stopAllLocalstackDockerCommand.execute();
-
- final LocalstackDockerConfiguration dockerConfig =
PROCESSOR.process(this.getClass());
- //Restart localstack docker after killing all the existing localstack
docker containers.
- //If it fails at this step, the test is terminated.
localstackDocker.startup(dockerConfig);
+ } catch (LocalstackDockerException e) {
Review comment:
Yes, incorporated this change now. Earlier this catch block had logic to
re-run the docker container in case it failed to start. But that is not
required now with the new logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
