mqliang commented on a change in pull request #7167:
URL: https://github.com/apache/incubator-pinot/pull/7167#discussion_r673478751
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/BaseDataTable.java
##########
@@ -44,21 +44,24 @@
protected DataSchema _dataSchema;
protected int[] _columnOffsets;
protected int _rowSizeInBytes;
+ // _dictionaryMap is only used in V2/V3, where each column use one
dictionary to map String->Integer
protected Map<String, Map<Integer, String>> _dictionaryMap;
+ // _dictionary is only used in V4, where all columns use a common dictionary
to map String->Integer
+ protected Map<Integer, String> _dictionary;
Review comment:
That's a good idea, using the index of list as an implicit dicId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
