mcvsubbu commented on a change in pull request #7173:
URL: https://github.com/apache/incubator-pinot/pull/7173#discussion_r674332083
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -74,60 +76,115 @@
}
public static class ControllerPeriodicTasksConf {
+
// frequency configs
+ @Deprecated
public static final String RETENTION_MANAGER_FREQUENCY_IN_SECONDS =
"controller.retention.frequencyInSeconds";
+ public static final String RETENTION_MANAGER_FREQUENCY_PERIOD =
"controller.retention.frequencyPeriod";
@Deprecated
// The ValidationManager has been split up into 3 separate tasks, each
having their own frequency config settings
public static final String
DEPRECATED_VALIDATION_MANAGER_FREQUENCY_IN_SECONDS =
"controller.validation.frequencyInSeconds";
+ @Deprecated
Review comment:
I was suggesting to just remove
`DEPRECATED_VALIDATION_MANAGER_FREQUENCY_IN_SECONDS`. It has been there since
0.5.0. I understand this can mean some more code to remove. If that is too
much, then you can choose to add a TODO there, saying that this config has been
deprecated as of 0.5.0, so must be removed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
