Jackie-Jiang commented on a change in pull request #7196:
URL: https://github.com/apache/pinot/pull/7196#discussion_r675865738
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerSelector.java
##########
@@ -25,4 +25,8 @@
* @return
*/
String selectBroker(String table);
+
+ default void close() {
Review comment:
Suggest making it not default to enforce all the implementation to close
the resources (it could be empty if it does not hold any resource)
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/DynamicBrokerSelector.java
##########
@@ -90,6 +91,14 @@ public String selectBroker(String table) {
return null;
}
+ @Override
+ public void close() {
+ if (_zkClient == null) {
Review comment:
`_zkClient` will never be `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
