Jackie-Jiang opened a new pull request #7241: URL: https://github.com/apache/pinot/pull/7241
## Description Make group trim size configurable for segment-level and server-level trim (both server config and query option). Currently server-level group trim size is hard-coded to `max(limit * 5, 5000)`, which might not be good enough for certain use cases that need better accuracy. This PR make the hard-coded 5000 configurable, and allow disabling the server-level group trim to get 100% accurate result. Note that disabling the trim or using a very high value could cause memory issue (similar to setting a super high limit), so use with cautious. Also make the segment-level group trim config keys (introduced in #7052) consistent with server-level group trim keys. ## Release Notes In server config: - `pinot.server.query.executor.min.segment.group.trim.size`: min segment-level group trim size, default -1 (disable segment-level trim) - `pinot.server.query.executor.min.server.group.trim.size`: min server-level group trim size, default 5000 (backward compatible) In query option: - `minSegmentGroupTrimSize`: override min segment-level group trim size (replacing `minSegmentTrimSize`) - `minServerGroupTrimSize`: override min server-level group trim size The following configs are removed: - `pinot.server.query.executor.enable.segment.group.trim` in server config is removed, as it is equivalent to setting min group trim size to -1 - `minSegmentTrimSize` in query option is replaced by `minSegmentGroupTrimSize` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
