Jackie-Jiang commented on a change in pull request #7244:
URL: https://github.com/apache/pinot/pull/7244#discussion_r681963767



##########
File path: 
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/IngestionJobLauncher.java
##########
@@ -145,7 +147,34 @@ private static void 
kickoffIngestionJob(SegmentGenerationJobSpec spec, String in
     }
   }
 
-  enum PinotIngestionJobType {
-    SegmentCreation, SegmentTarPush, SegmentUriPush, SegmentMetadataPush, 
SegmentCreationAndTarPush, SegmentCreationAndUriPush, 
SegmentCreationAndMetadataPush,
+  /**
+   * Ingestion Job type Enum.
+   */
+  public enum PinotIngestionJobType {
+    SegmentCreation,
+    SegmentTarPush,
+    SegmentUriPush,
+    SegmentMetadataPush,
+    SegmentCreationAndTarPush,
+    SegmentCreationAndUriPush,
+    SegmentCreationAndMetadataPush;
+
+    private static final Map<String, PinotIngestionJobType> VALUE_MAP = new 
HashMap<>();
+
+    static {
+      for (PinotIngestionJobType functionType : 
PinotIngestionJobType.values()) {

Review comment:
       (nit)
   ```suggestion
         for (PinotIngestionJobType jobType : PinotIngestionJobType.values()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to