klsince commented on a change in pull request #7265:
URL: https://github.com/apache/pinot/pull/7265#discussion_r685563646
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java
##########
@@ -152,6 +145,15 @@ protected void postProcess(PinotTaskConfig
pinotTaskConfig) {
}
}
+ // Delete the input segments
Review comment:
nit: can remove this one. it reads a bit redundant.
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java
##########
@@ -152,6 +145,15 @@ protected void postProcess(PinotTaskConfig
pinotTaskConfig) {
}
}
+ // Delete the input segments
+ // NOTE: Delete the input segments after tarring the converted segments
to avoid deleting the converted segment
+ // when the conversion happens in-place
Review comment:
when does the conversion happen in-place? is that valid case? I wonder
if some sanity check is needed instead of adjust the order here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
