klsince opened a new pull request #7286: URL: https://github.com/apache/pinot/pull/7286
## Description This RP starts to implement a feature to clean up obsolete indices during segment reload. As the first RP, 1. added a new method in SegmentDirectory iface, retainIndices() 2. added a helper method getIndicesFromTableConfig() as input param for retainIndices() 3. re-arranged the existing codes in SegmentPreprocessor to be more readable Use this one to get feedbacks on where change is to be added. Implementation comes in next RP. But still, lemme know if this should be split to smaller RPs for easy review. FYI, this one is different from https://github.com/apache/pinot/pull/7249 (which forces to download segment to overwrite local one for cleanup). This one does cleanup inside local segment folder, e.g. it removes obsolete indices from the columns.psf index file for v3 segment format. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
