jtao15 commented on a change in pull request #7289:
URL: https://github.com/apache/pinot/pull/7289#discussion_r687287038



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java
##########
@@ -204,8 +205,8 @@ private void checkCRC(HttpHeaders headers, String 
offlineTableName, String segme
   }
 
   private void processNewSegment(SegmentMetadata segmentMetadata, URI 
finalSegmentLocationURI,
-      File currentSegmentLocation, String zkDownloadURI, String crypter, 
String tableNameWithType, String segmentName,
-      boolean moveSegmentToFinalLocation) {
+      File currentSegmentLocation, String zkDownloadURI, HttpHeaders headers, 
String crypter, String tableNameWithType,

Review comment:
       Yes, I think you are right. Updated to handle `null` case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to