mcvsubbu commented on a change in pull request #7296: URL: https://github.com/apache/pinot/pull/7296#discussion_r688468134
########## File path: .github/workflows/pinot_compatibility_tests.yml ########## @@ -0,0 +1,50 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +name: Pinot Compatibility Regression Test + +on: + workflow_dispatch: + inputs: + oldCommit: + description: "Git hash (or tag) for old commit. If not specified, then previous commit is assumed" Review comment: For the ad hoc workflow, isnt it better to mandate old and new tag/commit values? ########## File path: .github/workflows/scripts/.pinot_compatibility_verifier.sh ########## @@ -45,6 +45,6 @@ echo "</settings>">> ${SETTINGS_FILE} # PINOT_MAVEN_OPTS is used to provide additional maven options to the checkoutAndBuild.sh command export PINOT_MAVEN_OPTS="-s $(pwd)/${SETTINGS_FILE}" -compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT +compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT -n $NEW_COMMIT Review comment: I wonder how this works if new commit is null. the command should error out, since there i a `-n` option, but no commit id given. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
