This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 43ffa03 Add TimeUnit to metrics in MinionQueryPhase (#7307)
43ffa03 is described below
commit 43ffa03f7558d0b3df5b137ece45b9ec5f072e24
Author: Jialiang Li <[email protected]>
AuthorDate: Mon Aug 16 10:29:23 2021 -0700
Add TimeUnit to metrics in MinionQueryPhase (#7307)
Co-authored-by: Jack Li(Analytics Engineering) <[email protected]>
---
.../org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
b/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
index 1913858..107610e 100644
---
a/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
+++
b/pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java
@@ -20,6 +20,7 @@ package org.apache.pinot.minion.taskfactory;
import java.util.HashMap;
import java.util.Map;
+import java.util.concurrent.TimeUnit;
import org.apache.commons.lang3.StringUtils;
import org.apache.helix.HelixManager;
import org.apache.helix.task.JobContext;
@@ -79,14 +80,17 @@ public class TaskFactoryRegistry {
// jobContext.getStartTime() return the time in milliseconds of
job being put into helix queue.
long jobInQueueTimeMs = jobContext.getStartTime();
long jobDequeueTimeMs = System.currentTimeMillis();
- _minionMetrics.addPhaseTiming(taskType,
MinionQueryPhase.TASK_QUEUEING, jobDequeueTimeMs - jobInQueueTimeMs);
+ _minionMetrics
+ .addPhaseTiming(taskType, MinionQueryPhase.TASK_QUEUEING,
jobDequeueTimeMs - jobInQueueTimeMs,
+ TimeUnit.MILLISECONDS);
try {
_minionMetrics.addValueToGlobalGauge(MinionGauge.NUMBER_OF_TASKS, 1L);
return runInternal();
} finally {
_minionMetrics.addValueToGlobalGauge(MinionGauge.NUMBER_OF_TASKS, -1L);
long executionTimeMs = System.currentTimeMillis() -
jobDequeueTimeMs;
- _minionMetrics.addPhaseTiming(taskType,
MinionQueryPhase.TASK_EXECUTION, executionTimeMs);
+ _minionMetrics
+ .addPhaseTiming(taskType, MinionQueryPhase.TASK_EXECUTION,
executionTimeMs, TimeUnit.MILLISECONDS);
LOGGER.info("Task: {} completed in: {}ms",
_taskConfig.getId(), executionTimeMs);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
