Jackie-Jiang commented on a change in pull request #7342:
URL: https://github.com/apache/pinot/pull/7342#discussion_r693189066
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java
##########
@@ -59,7 +59,11 @@
@Produces(MediaType.APPLICATION_JSON)
@Path("/debug/timeBoundary/{tableName}")
@ApiOperation(value = "Get the time boundary information for a table")
- @ApiResponses(value = {@ApiResponse(code = 200, message = "Time boundary
information for a table"), @ApiResponse(code = 404, message = "Time boundary
not found"), @ApiResponse(code = 500, message = "Internal server error")})
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Time boundary information for a
table"),
Review comment:
Break them to one `ApiResponse` per line?
Same for other rest api methods
##########
File path:
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/utils/Constants.java
##########
@@ -34,19 +34,26 @@ private Constants() {
public static final String[] SCHEMA_COLUMNS_DTYPES = {"STRING", "STRING"};
public static final String[] TABLE_COLUMNS =
- {"TABLE_SCHEM", "TABLE_CATALOG", "TABLE_NAME", "TABLE_TYPE", "REMARKS",
"TYPE_CAT", "TYPE_SCHEM", "TYPE_NAME",
- "SELF_REFERENCING_COL_NAME", "REF_GENERATION"};
+ {
+ "TABLE_SCHEM", "TABLE_CATALOG", "TABLE_NAME", "TABLE_TYPE",
"REMARKS", "TYPE_CAT", "TYPE_SCHEM", "TYPE_NAME",
+ "SELF_REFERENCING_COL_NAME", "REF_GENERATION"
+ };
public static final String[] TABLE_COLUMNS_DTYPES =
{"STRING", "STRING", "STRING", "STRING", "STRING", "STRING", "STRING",
"STRING", "STRING", "STRING"};
public static final String[] TABLE_SCHEMA_COLUMNS =
- {"TABLE_CAT", "TABLE_SCHEM", "TABLE_NAME", "COLUMN_NAME", "DATA_TYPE",
"TYPE_NAME", "COLUMN_SIZE", "BUFFER_LENGTH", "DECIMAL_DIGITS",
- "NUM_PREC_RADIX", "NULLABLE", "REMARKS", "COLUMN_DEF",
"SQL_DATA_TYPE", "SQL_DATETIME_SUB", "CHAR_OCTET_LENGTH",
- "ORDINAL_POSITION", "IS_NULLABLE", "SCOPE_CATALOG", "SCOPE_SCHEMA",
"SCOPE_TABLE", "SOURCE_DATA_TYPE", "IS_AUTOINCREMENT",
- "IS_GENERATEDCOLUMN"};
+ {
+ "TABLE_CAT", "TABLE_SCHEM", "TABLE_NAME", "COLUMN_NAME",
"DATA_TYPE", "TYPE_NAME", "COLUMN_SIZE",
+ "BUFFER_LENGTH", "DECIMAL_DIGITS", "NUM_PREC_RADIX", "NULLABLE",
"REMARKS", "COLUMN_DEF", "SQL_DATA_TYPE",
+ "SQL_DATETIME_SUB", "CHAR_OCTET_LENGTH", "ORDINAL_POSITION",
"IS_NULLABLE", "SCOPE_CATALOG", "SCOPE_SCHEMA",
+ "SCOPE_TABLE", "SOURCE_DATA_TYPE", "IS_AUTOINCREMENT",
"IS_GENERATEDCOLUMN"
+ };
public static final String[] TABLE_SCHEMA_COLUMNS_DTYPES =
- {"STRING", "STRING", "STRING", "STRING", "INT", "STRING", "INT", "INT",
"INT", "INT", "INT", "STRING", "STRING", "INT", "INT", "INT",
- "INT", "STRING", "STRING", "STRING", "STRING", "INT", "STRING",
"STRING"};
+ {
+ "STRING", "STRING", "STRING", "STRING", "INT", "STRING", "INT",
"INT", "INT", "INT", "INT", "STRING",
+ "STRING",
Review comment:
Reformat
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/TimeSegmentPruner.java
##########
@@ -194,8 +196,10 @@ public synchronized void refreshSegment(String segment) {
}
/**
- * @return Null if no time condition or cannot filter base on the condition
(e.g. 'SELECT * from myTable where time < 50 OR firstName = Jason')
- * Empty list if time condition is specified but invalid (e.g.
'SELECT * from myTable where time < 50 AND time > 100')
+ * @return Null if no time condition or cannot filter base on the condition
(e.g. 'SELECT * from myTable where time
+ * < 50 OR firstName = Jason')
Review comment:
Reformat
##########
File path:
pinot-clients/pinot-jdbc-client/src/test/java/org/apache/pinot/client/PinotPreparedStatementTest.java
##########
@@ -54,7 +55,8 @@ public void testSetAndClearValues()
String lastExecutedQuery = _dummyPinotClientTransport.getLastQuery();
Assert.assertEquals(lastExecutedQuery.substring(0,
lastExecutedQuery.indexOf("LIMIT")).trim(),
- "SELECT * FROM dummy WHERE name = 'foo' and age = 20 and score = 98.1
and ts = 123456789 and eligible = 'true' and sub_score = 1"
+ "SELECT * FROM dummy WHERE name = 'foo' and age = 20 and score = 98.1
and ts = 123456789 and eligible = "
+ + "'true' and sub_score = 1"
Review comment:
Reformat
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/TimeSegmentPruner.java
##########
@@ -325,8 +329,10 @@ public synchronized void refreshSegment(String segment) {
}
/**
- * @return Null if no time condition or cannot filter base on the condition
(e.g. 'SELECT * from myTable where time < 50 OR firstName = Jason')
- * @return Empty list if time condition is specified but invalid (e.g.
'SELECT * from myTable where time < 50 AND time > 100')
+ * @return Null if no time condition or cannot filter base on the condition
(e.g. 'SELECT * from myTable where time
+ * < 50 OR firstName = Jason')
Review comment:
Reformat
##########
File path:
pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ExecutionStatsTest.java
##########
@@ -39,9 +39,12 @@
public void setUp()
throws Exception {
String json =
- "{\"numServersQueried\":10, \"numServersResponded\":10,
\"numDocsScanned\":10, \"numEntriesScannedInFilter\":10, "
- + "\"numEntriesScannedPostFilter\":10, \"numSegmentsQueried\":10,
\"numSegmentsProcessed\":10, \"numSegmentsMatched\":10, "
- + "\"numConsumingSegmentsQueried\":10,
\"minConsumingFreshnessTimeMs\":10, \"totalDocs\":10,
\"numGroupsLimitReached\":true, "
+ "{\"numServersQueried\":10, \"numServersResponded\":10,
\"numDocsScanned\":10, "
Review comment:
Can we reformat this? Same for other places
I think this is caused by reformatting twice, first time 140 then 120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
