snleee commented on a change in pull request #7346:
URL: https://github.com/apache/pinot/pull/7346#discussion_r693267519
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java
##########
@@ -110,11 +113,20 @@ public SegmentProcessorFramework(List<RecordReader>
recordReaders, SegmentProces
// Segment creation phase
LOGGER.info("Beginning segment creation phase on partitions: {}",
partitionToFileManagerMap.keySet());
List<File> outputSegmentDirs = new ArrayList<>();
- SegmentGeneratorConfig generatorConfig =
- new SegmentGeneratorConfig(_segmentProcessorConfig.getTableConfig(),
_segmentProcessorConfig.getSchema());
+ TableConfig tableConfig = _segmentProcessorConfig.getTableConfig();
+ Schema schema = _segmentProcessorConfig.getSchema();
+ String segmentNamePrefix =
_segmentProcessorConfig.getSegmentConfig().getSegmentNamePrefix();
+ SegmentGeneratorConfig generatorConfig = new
SegmentGeneratorConfig(tableConfig, schema);
generatorConfig.setOutDir(_segmentsOutputDir.getPath());
- // TODO: Use NormalizedDateSegmentNameGenerator
-
generatorConfig.setSegmentNamePrefix(_segmentProcessorConfig.getSegmentConfig().getSegmentNamePrefix());
+
+ if (tableConfig.getIndexingConfig() != null
Review comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
