Jackie-Jiang commented on a change in pull request #7364:
URL: https://github.com/apache/pinot/pull/7364#discussion_r695979676
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ZookeeperResource.java
##########
@@ -139,7 +140,17 @@ public SuccessResponse putData(
@ApiParam(value = "expectedVersion", required = true, defaultValue =
"-1") @QueryParam("expectedVersion")
@DefaultValue("-1") String expectedVersion,
@ApiParam(value = "accessOption", required = true, defaultValue = "1")
@QueryParam("accessOption")
- @DefaultValue("1") String accessOption) {
+ @DefaultValue("1") String accessOption,
+ @ApiParam(value = "payload") @Nullable Payload payload
Review comment:
We don't want it to be an api param, but the actual payload for the PUT
http call. The payload should be the same as the content, but not as an api
param. Also we need to change content to be optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
