walterddr commented on pull request #7114: URL: https://github.com/apache/pinot/pull/7114#issuecomment-918270810
> > Let's also add the scalar function version of it which can be used during data ingestion > > could you share how the scalarFunction wrapper could be tested in ingestion? > > Also I dont know if this is a good idea on a second thought: > in the regex spect, regex pattern actually only accepts string literal (it doesn't support column), so it would be super inefficient to do a per-row pattern compilation. I added the ScalarFunctionWrapper support in ba1262e. Please kindly take a look. Actually I think there might be some optimization we can do when LITERAL is passed in by making the FunctionInfo a bit stateful. but that's for a different optimization PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
