Jackie-Jiang commented on a change in pull request #7454: URL: https://github.com/apache/pinot/pull/7454#discussion_r712615224
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,168 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.*; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int RANGE_INDEX_VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final FieldSpec.DataType _valueType; + private final long _minValue; + private final double _scale; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _valueType = metadata.getDataType(); + _minValue = minValue(metadata); + _scale = scale(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { + } + + @Override + public void add(long value) { + _appender.add(value - _minValue); + } + + @Override + public void add(long[] values, int length) { + } + + @Override + public void add(float value) { + if (!Float.isFinite(value)) { + // TODO this probably needs better handling, like using a 24th slice + // for infinite values + _appender.add(0); + } else { + double d = value; + d -= Double.longBitsToDouble(_minValue); + d *= _scale; + _appender.add(Float.floatToIntBits((float) d)); + } + } + + @Override + public void add(float[] values, int length) { + } + + @Override + public void add(double value) { + if (!Double.isFinite(value)) { + // TODO this probably needs better handling, like using a 57th slice + // for infinite values + _appender.add(0L); + } else { + value -= Double.longBitsToDouble(_minValue); + value *= _scale; + _appender.add(Double.doubleToLongBits(value)); + } + } + + @Override + public void add(double[] values, int length) { + } + + @Override + public void seal() throws IOException { + int headerSize = Integer.BYTES + Long.BYTES + (_valueType == FLOAT || _valueType == DOUBLE ? Double.BYTES : 0); + int serializedSize = _appender.serializedSizeInBytes(); + try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) { + writer.write(buf -> { + buf.putInt(RANGE_INDEX_VERSION); + buf.putLong(_minValue); + if (_valueType == FLOAT || _valueType == DOUBLE) { + buf.putDouble(_scale); + } + _appender.serialize(buf); + }); + } + _appender.clear(); + } + + @Override + public void close() throws IOException { + + } + + private static long maxValue(ColumnMetadata metadata) { + FieldSpec.DataType dataType = metadata.getDataType(); + if (dataType == LONG || dataType == INT) { + Comparable<?> minValue = metadata.getMinValue(); + Comparable<?> maxValue = metadata.getMaxValue(); + if (minValue instanceof Number && maxValue instanceof Number) { + return ((Number) maxValue).longValue() - ((Number) minValue).longValue(); + } + } + if (dataType == DOUBLE) { + return 1L << 55; + } + if (dataType == FLOAT) { + return 1L << 22; + } + return Long.MAX_VALUE; + } + + private static long minValue(ColumnMetadata metadata) { Review comment: Similarly, check if it has dictionary before the data type check ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,168 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.*; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int RANGE_INDEX_VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final FieldSpec.DataType _valueType; + private final long _minValue; + private final double _scale; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _valueType = metadata.getDataType(); + _minValue = minValue(metadata); + _scale = scale(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { + } + + @Override + public void add(long value) { + _appender.add(value - _minValue); + } + + @Override + public void add(long[] values, int length) { + } + + @Override + public void add(float value) { + if (!Float.isFinite(value)) { + // TODO this probably needs better handling, like using a 24th slice + // for infinite values + _appender.add(0); + } else { + double d = value; + d -= Double.longBitsToDouble(_minValue); + d *= _scale; + _appender.add(Float.floatToIntBits((float) d)); + } + } + + @Override + public void add(float[] values, int length) { + } + + @Override + public void add(double value) { + if (!Double.isFinite(value)) { + // TODO this probably needs better handling, like using a 57th slice + // for infinite values + _appender.add(0L); + } else { + value -= Double.longBitsToDouble(_minValue); + value *= _scale; + _appender.add(Double.doubleToLongBits(value)); + } + } + + @Override + public void add(double[] values, int length) { + } + + @Override + public void seal() throws IOException { + int headerSize = Integer.BYTES + Long.BYTES + (_valueType == FLOAT || _valueType == DOUBLE ? Double.BYTES : 0); + int serializedSize = _appender.serializedSizeInBytes(); + try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) { + writer.write(buf -> { + buf.putInt(RANGE_INDEX_VERSION); + buf.putLong(_minValue); + if (_valueType == FLOAT || _valueType == DOUBLE) { + buf.putDouble(_scale); + } + _appender.serialize(buf); + }); + } + _appender.clear(); + } + + @Override + public void close() throws IOException { + + } + + private static long maxValue(ColumnMetadata metadata) { + FieldSpec.DataType dataType = metadata.getDataType(); + if (dataType == LONG || dataType == INT) { + Comparable<?> minValue = metadata.getMinValue(); + Comparable<?> maxValue = metadata.getMaxValue(); + if (minValue instanceof Number && maxValue instanceof Number) { + return ((Number) maxValue).longValue() - ((Number) minValue).longValue(); + } + } + if (dataType == DOUBLE) { Review comment: Putting some comments on how it works would be good ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,168 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.*; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int RANGE_INDEX_VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final FieldSpec.DataType _valueType; + private final long _minValue; + private final double _scale; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _valueType = metadata.getDataType(); + _minValue = minValue(metadata); + _scale = scale(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { + } + + @Override + public void add(long value) { + _appender.add(value - _minValue); + } + + @Override + public void add(long[] values, int length) { + } + + @Override + public void add(float value) { + if (!Float.isFinite(value)) { + // TODO this probably needs better handling, like using a 24th slice + // for infinite values + _appender.add(0); + } else { + double d = value; + d -= Double.longBitsToDouble(_minValue); + d *= _scale; + _appender.add(Float.floatToIntBits((float) d)); + } + } + + @Override + public void add(float[] values, int length) { + } + + @Override + public void add(double value) { + if (!Double.isFinite(value)) { + // TODO this probably needs better handling, like using a 57th slice + // for infinite values + _appender.add(0L); + } else { + value -= Double.longBitsToDouble(_minValue); + value *= _scale; + _appender.add(Double.doubleToLongBits(value)); + } + } + + @Override + public void add(double[] values, int length) { + } + + @Override + public void seal() throws IOException { + int headerSize = Integer.BYTES + Long.BYTES + (_valueType == FLOAT || _valueType == DOUBLE ? Double.BYTES : 0); + int serializedSize = _appender.serializedSizeInBytes(); + try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) { + writer.write(buf -> { + buf.putInt(RANGE_INDEX_VERSION); + buf.putLong(_minValue); + if (_valueType == FLOAT || _valueType == DOUBLE) { + buf.putDouble(_scale); + } + _appender.serialize(buf); + }); + } + _appender.clear(); + } + + @Override + public void close() throws IOException { + + } + + private static long maxValue(ColumnMetadata metadata) { Review comment: Should check if the column has dictionary, and return cardinality if it is dictionary-encoded ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java ########## @@ -175,7 +176,15 @@ public PhysicalColumnIndexContainer(SegmentDirectory.Reader segmentReader, Colum } if (loadRangeIndex) { - _rangeIndex = new RangeIndexReaderImpl(segmentReader.getIndexFor(columnName, ColumnIndexType.RANGE_INDEX)); + PinotDataBuffer buffer = segmentReader.getIndexFor(columnName, ColumnIndexType.RANGE_INDEX); + int version = buffer.getInt(0); + if (version == 0) { + _rangeIndex = new RangeIndexReaderImpl(buffer); + } else if (version == 1) { + _rangeIndex = new BitSlicedRangeIndexReader(buffer, metadata); + } else { + _rangeIndex = null; Review comment: Suggest throwing exception when getting an file of unknown version ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java ########## @@ -304,6 +306,13 @@ public void setReadMode(ReadMode readMode) { public Map<String, Map<String, String>> getColumnProperties() { return _columnProperties; } + public int getRangeIndexVersion() { Review comment: `IndexLoadingConfig` is not exposed to the user, but initialized from the table config. We can put this index version into the `IndexingConfig` which is a sub-config under the `TableConfig` so that user can specify the range index version they want to generate. ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java ########## @@ -0,0 +1,171 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.index.readers; + +import java.io.IOException; +import java.lang.ref.SoftReference; +import java.nio.ByteBuffer; +import java.util.concurrent.atomic.AtomicReferenceFieldUpdater; +import javax.annotation.Nullable; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.reader.RangeIndexReader; +import org.apache.pinot.segment.spi.memory.PinotDataBuffer; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; +import org.roaringbitmap.RoaringBitmap; +import org.roaringbitmap.buffer.ImmutableRoaringBitmap; + +import static org.apache.pinot.spi.data.FieldSpec.DataType.DOUBLE; +import static org.apache.pinot.spi.data.FieldSpec.DataType.FLOAT; + +public class BitSlicedRangeIndexReader implements RangeIndexReader<ImmutableRoaringBitmap> { + + @SuppressWarnings("rawtypes") + private static final AtomicReferenceFieldUpdater<BitSlicedRangeIndexReader, SoftReference> UPDATER = + AtomicReferenceFieldUpdater.newUpdater(BitSlicedRangeIndexReader.class, SoftReference.class, + "_rangeBitmapRef"); + + private final PinotDataBuffer _dataBuffer; + private final long _offset; + private final long _min; + private final double _scale; + private volatile SoftReference<RangeBitmap> _rangeBitmapRef; + + public BitSlicedRangeIndexReader(PinotDataBuffer dataBuffer, ColumnMetadata metadata) { Review comment: Dictionary encoded column is not handled in the reader ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,168 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.*; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int RANGE_INDEX_VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final FieldSpec.DataType _valueType; + private final long _minValue; + private final double _scale; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _valueType = metadata.getDataType(); + _minValue = minValue(metadata); + _scale = scale(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { Review comment: throw `UnsupportedOperationException` to prevent callers from calling this method ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java ########## @@ -49,6 +49,7 @@ public class IndexLoadingConfig { private static final int DEFAULT_REALTIME_AVG_MULTI_VALUE_COUNT = 2; public static final String DEFAULT_TIER_BACKEND = "local"; + private static final int DEFAULT_RANGE_INDEX_VERSION = 1; Review comment: +1 on putting one as the default version. Once all pinot components are deployed, user can start generating the new index version ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,168 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.*; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int RANGE_INDEX_VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final FieldSpec.DataType _valueType; + private final long _minValue; + private final double _scale; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _valueType = metadata.getDataType(); + _minValue = minValue(metadata); + _scale = scale(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { + } + + @Override + public void add(long value) { + _appender.add(value - _minValue); + } + + @Override + public void add(long[] values, int length) { + } + + @Override + public void add(float value) { + if (!Float.isFinite(value)) { + // TODO this probably needs better handling, like using a 24th slice + // for infinite values + _appender.add(0); + } else { + double d = value; + d -= Double.longBitsToDouble(_minValue); + d *= _scale; + _appender.add(Float.floatToIntBits((float) d)); + } + } + + @Override + public void add(float[] values, int length) { + } + + @Override + public void add(double value) { + if (!Double.isFinite(value)) { + // TODO this probably needs better handling, like using a 57th slice + // for infinite values + _appender.add(0L); + } else { + value -= Double.longBitsToDouble(_minValue); + value *= _scale; + _appender.add(Double.doubleToLongBits(value)); + } + } + + @Override + public void add(double[] values, int length) { + } + + @Override + public void seal() throws IOException { + int headerSize = Integer.BYTES + Long.BYTES + (_valueType == FLOAT || _valueType == DOUBLE ? Double.BYTES : 0); + int serializedSize = _appender.serializedSizeInBytes(); + try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) { + writer.write(buf -> { + buf.putInt(RANGE_INDEX_VERSION); + buf.putLong(_minValue); + if (_valueType == FLOAT || _valueType == DOUBLE) { + buf.putDouble(_scale); + } + _appender.serialize(buf); + }); + } + _appender.clear(); + } + + @Override + public void close() throws IOException { + + } + + private static long maxValue(ColumnMetadata metadata) { + FieldSpec.DataType dataType = metadata.getDataType(); + if (dataType == LONG || dataType == INT) { + Comparable<?> minValue = metadata.getMinValue(); + Comparable<?> maxValue = metadata.getMaxValue(); + if (minValue instanceof Number && maxValue instanceof Number) { + return ((Number) maxValue).longValue() - ((Number) minValue).longValue(); + } + } + if (dataType == DOUBLE) { + return 1L << 55; + } + if (dataType == FLOAT) { + return 1L << 22; + } + return Long.MAX_VALUE; + } + + private static long minValue(ColumnMetadata metadata) { + FieldSpec.DataType dataType = metadata.getDataType(); + Comparable<?> minValue = metadata.getMinValue(); + if (minValue instanceof Number) { + if (dataType == LONG || dataType == INT) { + return ((Number) minValue).longValue(); + } else if (dataType == DOUBLE || dataType == FLOAT) { + return Double.doubleToLongBits(((Number) minValue).doubleValue()); + } + } + return 0L; + } + + private static double scale(ColumnMetadata metadata) { + FieldSpec.DataType dataType = metadata.getDataType(); + Comparable<?> minValue = metadata.getMinValue(); + Comparable<?> maxValue = metadata.getMaxValue(); + if (minValue instanceof Number && maxValue instanceof Number) { + if (dataType == DOUBLE || dataType == FLOAT) { + // if the range were zero, we wouldn't be creating a range index + // min and max should be finite (but this needs to be verified) Review comment: I think min and max can be infinite here. If we got infinite value, we might need to assume full value range -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
