Jackie-Jiang commented on a change in pull request #7454: URL: https://github.com/apache/pinot/pull/7454#discussion_r715231224
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/FPOrdering.java ########## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.utils; + +public class FPOrdering { + + private FPOrdering() { + } + + /** + * Maps doubles to longs with the same total (unsigned) order + * NEGATIVE_INFINITY is considered less than or equal to all values. + * NaN and POSITIVE_INFINITY are considered greater than or equal to all values. + * + * @param value a double value + * @return an ordinal + */ + public static long ordinalOf(double value) { + if (value == Double.NEGATIVE_INFINITY) { + return 0; + } + if (value == Double.POSITIVE_INFINITY || Double.isNaN(value)) { + return 0xFFFFFFFFFFFFFFFFL; + } + long bits = Double.doubleToLongBits(value); + // need negatives to come before positives + if ((bits & Long.MIN_VALUE) == Long.MIN_VALUE) { + // conflate 0/-0, or reverse order of negatives + bits = bits == Long.MIN_VALUE ? Long.MIN_VALUE : ~bits; + } else { // positives after negatives + bits ^= Long.MIN_VALUE; + } + return bits; + } + + /** + * Maps doubles to ints with the same total (unsigned) order + * NEGATIVE_INFINITY is considered less than or equal to all values. + * NaN and POSITIVE_INFINITY are considered greater than or equal to all values. + * + * @param value a double value + * @return an ordinal + */ + public static long ordinalOf(float value) { + if (value == Double.NEGATIVE_INFINITY) { + return 0; + } + if (value == Double.POSITIVE_INFINITY || Double.isNaN(value)) { + return 0xFFFFFFFF; + } Review comment: (nit) ```suggestion if (value == Float.NEGATIVE_INFINITY) { return 0; } if (value == Float.POSITIVE_INFINITY || Float.isNaN(value)) { return 0xFFFFFFFF; } ``` ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.local.utils.FPOrdering; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.DOUBLE; +import static org.apache.pinot.spi.data.FieldSpec.DataType.FLOAT; +import static org.apache.pinot.spi.data.FieldSpec.DataType.INT; +import static org.apache.pinot.spi.data.FieldSpec.DataType.LONG; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final long _minValue; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _minValue = minValue(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(long value) { + _appender.add(value - _minValue); + } + + @Override + public void add(long[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(float value) { + _appender.add(FPOrdering.ordinalOf(value)); + } + + @Override + public void add(float[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(double value) { + _appender.add(FPOrdering.ordinalOf(value)); + } + + @Override + public void add(double[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void seal() throws IOException { + int headerSize = Integer.BYTES + Long.BYTES; + int serializedSize = _appender.serializedSizeInBytes(); + try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) { + writer.write(buf -> { + buf.putInt(VERSION); + buf.putLong(_minValue); + _appender.serialize(buf); + }); + } + _appender.clear(); + } + + @Override + public void close() throws IOException { + + } + + private static long maxValue(ColumnMetadata metadata) { + if (metadata.hasDictionary()) { + return metadata.getCardinality(); Review comment: ```suggestion return metadata.getCardinality() - 1; ``` ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/RangeIndexHandler.java ########## @@ -48,13 +52,18 @@ private final SegmentMetadata _segmentMetadata; private final SegmentDirectory.Writer _segmentWriter; private final Set<String> _columnsToAddIdx; + private final int _rangeIndexVersion; public RangeIndexHandler(File indexDir, SegmentMetadata segmentMetadata, IndexLoadingConfig indexLoadingConfig, SegmentDirectory.Writer segmentWriter) { _indexDir = indexDir; _segmentMetadata = segmentMetadata; _segmentWriter = segmentWriter; _columnsToAddIdx = new HashSet<>(indexLoadingConfig.getRangeIndexColumns()); + // guard against null table config + _rangeIndexVersion = Optional.ofNullable(indexLoadingConfig.getTableConfig()) Review comment: We can add the `_rangeIndexVersion` as a field in the `IndexLoadingConfig`, and allow overriding it with table config. That's the way we handle other index related configs ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/FPOrdering.java ########## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.utils; + +public class FPOrdering { + + private FPOrdering() { + } + + /** + * Maps doubles to longs with the same total (unsigned) order + * NEGATIVE_INFINITY is considered less than or equal to all values. + * NaN and POSITIVE_INFINITY are considered greater than or equal to all values. Review comment: Any specific reason mapping `NaN` to `POSITIVE_INFINITY`? I feel mapping to `NEGATIVE_INFINITY` might be slightly better as we use `NEGATIVE_INFINITY` as the default dimension value ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,168 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.*; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int RANGE_INDEX_VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final FieldSpec.DataType _valueType; + private final long _minValue; + private final double _scale; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _valueType = metadata.getDataType(); + _minValue = minValue(metadata); + _scale = scale(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { + } + + @Override + public void add(long value) { + _appender.add(value - _minValue); + } + + @Override + public void add(long[] values, int length) { + } + + @Override + public void add(float value) { + if (!Float.isFinite(value)) { + // TODO this probably needs better handling, like using a 24th slice + // for infinite values + _appender.add(0); + } else { + double d = value; + d -= Double.longBitsToDouble(_minValue); + d *= _scale; + _appender.add(Float.floatToIntBits((float) d)); + } + } + + @Override + public void add(float[] values, int length) { + } + + @Override + public void add(double value) { + if (!Double.isFinite(value)) { + // TODO this probably needs better handling, like using a 57th slice + // for infinite values + _appender.add(0L); + } else { + value -= Double.longBitsToDouble(_minValue); + value *= _scale; + _appender.add(Double.doubleToLongBits(value)); + } + } + + @Override + public void add(double[] values, int length) { + } + + @Override + public void seal() throws IOException { + int headerSize = Integer.BYTES + Long.BYTES + (_valueType == FLOAT || _valueType == DOUBLE ? Double.BYTES : 0); + int serializedSize = _appender.serializedSizeInBytes(); + try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) { + writer.write(buf -> { + buf.putInt(RANGE_INDEX_VERSION); + buf.putLong(_minValue); + if (_valueType == FLOAT || _valueType == DOUBLE) { + buf.putDouble(_scale); + } + _appender.serialize(buf); + }); + } + _appender.clear(); + } + + @Override + public void close() throws IOException { + + } + + private static long maxValue(ColumnMetadata metadata) { + FieldSpec.DataType dataType = metadata.getDataType(); + if (dataType == LONG || dataType == INT) { + Comparable<?> minValue = metadata.getMinValue(); + Comparable<?> maxValue = metadata.getMaxValue(); + if (minValue instanceof Number && maxValue instanceof Number) { + return ((Number) maxValue).longValue() - ((Number) minValue).longValue(); + } + } + if (dataType == DOUBLE) { + return 1L << 55; + } + if (dataType == FLOAT) { + return 1L << 22; + } + return Long.MAX_VALUE; Review comment: Suggest throwing exception when data type is not number since it won't work ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java ########## @@ -0,0 +1,120 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.index.readers; + +import java.io.IOException; +import java.nio.ByteBuffer; +import javax.annotation.Nullable; +import org.apache.pinot.segment.local.segment.creator.impl.inv.BitSlicedRangeIndexCreator; +import org.apache.pinot.segment.local.utils.FPOrdering; +import org.apache.pinot.segment.spi.index.reader.RangeIndexReader; +import org.apache.pinot.segment.spi.memory.PinotDataBuffer; +import org.roaringbitmap.RangeBitmap; +import org.roaringbitmap.RoaringBitmap; +import org.roaringbitmap.buffer.ImmutableRoaringBitmap; + +public class BitSlicedRangeIndexReader implements RangeIndexReader<ImmutableRoaringBitmap> { + + private final PinotDataBuffer _dataBuffer; + private final long _offset; + private final long _min; + + public BitSlicedRangeIndexReader(PinotDataBuffer dataBuffer) { + _dataBuffer = dataBuffer; + long offset = 0; + + int version = dataBuffer.getInt(offset); + assert version == BitSlicedRangeIndexCreator.VERSION : "invalid version"; + offset += Integer.BYTES; + + _min = dataBuffer.getLong(offset); + offset += Long.BYTES; + + this._offset = offset; Review comment: (nit) remove `this.` ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.local.utils.FPOrdering; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.DOUBLE; +import static org.apache.pinot.spi.data.FieldSpec.DataType.FLOAT; +import static org.apache.pinot.spi.data.FieldSpec.DataType.INT; +import static org.apache.pinot.spi.data.FieldSpec.DataType.LONG; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final long _minValue; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _minValue = minValue(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(long value) { + _appender.add(value - _minValue); + } + + @Override + public void add(long[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(float value) { + _appender.add(FPOrdering.ordinalOf(value)); + } + + @Override + public void add(float[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(double value) { + _appender.add(FPOrdering.ordinalOf(value)); + } + + @Override + public void add(double[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void seal() throws IOException { + int headerSize = Integer.BYTES + Long.BYTES; + int serializedSize = _appender.serializedSizeInBytes(); + try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) { + writer.write(buf -> { + buf.putInt(VERSION); + buf.putLong(_minValue); + _appender.serialize(buf); + }); + } + _appender.clear(); + } + + @Override + public void close() throws IOException { + + } + + private static long maxValue(ColumnMetadata metadata) { + if (metadata.hasDictionary()) { + return metadata.getCardinality(); + } + FieldSpec.DataType dataType = metadata.getDataType(); + Comparable<?> minValue = metadata.getMinValue(); + Comparable<?> maxValue = metadata.getMaxValue(); + if (dataType == LONG || dataType == INT) { + if (minValue instanceof Number && maxValue instanceof Number) { Review comment: Suggest not checking the instance of the value, and let it throw cast exception if it is not number. This should not happen, and if it happens we want to fail fast ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.local.utils.FPOrdering; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.DOUBLE; +import static org.apache.pinot.spi.data.FieldSpec.DataType.FLOAT; +import static org.apache.pinot.spi.data.FieldSpec.DataType.INT; +import static org.apache.pinot.spi.data.FieldSpec.DataType.LONG; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final long _minValue; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _minValue = minValue(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(long value) { + _appender.add(value - _minValue); + } + + @Override + public void add(long[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(float value) { + _appender.add(FPOrdering.ordinalOf(value)); + } + + @Override + public void add(float[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(double value) { + _appender.add(FPOrdering.ordinalOf(value)); + } + + @Override + public void add(double[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void seal() throws IOException { + int headerSize = Integer.BYTES + Long.BYTES; + int serializedSize = _appender.serializedSizeInBytes(); + try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) { + writer.write(buf -> { + buf.putInt(VERSION); + buf.putLong(_minValue); + _appender.serialize(buf); + }); + } + _appender.clear(); + } + + @Override + public void close() throws IOException { + + } + + private static long maxValue(ColumnMetadata metadata) { + if (metadata.hasDictionary()) { + return metadata.getCardinality(); + } + FieldSpec.DataType dataType = metadata.getDataType(); Review comment: We should check for stored type so that we can apply range index to `TIMESTAMP` ```suggestion FieldSpec.DataType dataType = metadata.getDataType().storedType(); ``` ########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ########## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.creator.impl.inv; + +import java.io.File; +import java.io.IOException; +import org.apache.pinot.segment.local.utils.FPOrdering; +import org.apache.pinot.segment.spi.ColumnMetadata; +import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator; +import org.apache.pinot.spi.data.FieldSpec; +import org.roaringbitmap.RangeBitmap; + +import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION; +import static org.apache.pinot.spi.data.FieldSpec.DataType.DOUBLE; +import static org.apache.pinot.spi.data.FieldSpec.DataType.FLOAT; +import static org.apache.pinot.spi.data.FieldSpec.DataType.INT; +import static org.apache.pinot.spi.data.FieldSpec.DataType.LONG; + +public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator { + + public static final int VERSION = 2; + + private final RangeBitmap.Appender _appender; + private final File _rangeIndexFile; + private final long _minValue; + + public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) { + _appender = RangeBitmap.appender(maxValue(metadata)); + _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION); + _minValue = minValue(metadata); + } + + @Override + public void add(int dictId) { + _appender.add(dictId - _minValue); + } + + @Override + public void add(int[] dictIds, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(long value) { + _appender.add(value - _minValue); + } + + @Override + public void add(long[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(float value) { + _appender.add(FPOrdering.ordinalOf(value)); + } + + @Override + public void add(float[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void add(double value) { + _appender.add(FPOrdering.ordinalOf(value)); + } + + @Override + public void add(double[] values, int length) { + throw new UnsupportedOperationException("MV not supported"); + } + + @Override + public void seal() throws IOException { + int headerSize = Integer.BYTES + Long.BYTES; + int serializedSize = _appender.serializedSizeInBytes(); + try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) { + writer.write(buf -> { + buf.putInt(VERSION); + buf.putLong(_minValue); + _appender.serialize(buf); + }); + } + _appender.clear(); + } + + @Override + public void close() throws IOException { + + } + + private static long maxValue(ColumnMetadata metadata) { + if (metadata.hasDictionary()) { + return metadata.getCardinality(); + } + FieldSpec.DataType dataType = metadata.getDataType(); + Comparable<?> minValue = metadata.getMinValue(); + Comparable<?> maxValue = metadata.getMaxValue(); + if (dataType == LONG || dataType == INT) { + if (minValue instanceof Number && maxValue instanceof Number) { + return ((Number) maxValue).longValue() - ((Number) minValue).longValue(); + } + } + if (dataType == DOUBLE) { + return 0xFFFFFFFFFFFFFFFFL; + } + if (dataType == FLOAT) { + return 0xFFFFFFFFL; + } + return Long.MAX_VALUE; + } + + private static long minValue(ColumnMetadata metadata) { + if (metadata.hasDictionary()) { + return 0; + } + FieldSpec.DataType dataType = metadata.getDataType(); + Comparable<?> minValue = metadata.getMinValue(); + if (minValue instanceof Number) { Review comment: Similar here, suggest let it throw cast exception to fail fast ########## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/FPOrderingTest.java ########## @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.utils; + +import java.util.Arrays; +import java.util.concurrent.ThreadLocalRandom; +import java.util.function.IntUnaryOperator; +import java.util.stream.IntStream; +import org.testng.annotations.Test; + +import static org.testng.Assert.assertEquals; +import static org.testng.Assert.assertTrue; + +public class FPOrderingTest { + + @Test + public void testNaN() { + assertEquals(0xFFFFFFFFFFFFFFFFL, FPOrdering.ordinalOf(Double.NaN)); Review comment: (minor) The first value is actual, and the second one is expected (easier to debug when test fails). Same for other places ```suggestion assertEquals(FPOrdering.ordinalOf(Double.NaN), 0xFFFFFFFFFFFFFFFFL); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
