jackjlli commented on a change in pull request #7490:
URL: https://github.com/apache/pinot/pull/7490#discussion_r717266533
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotSegmentsMetadataTest.java
##########
@@ -113,7 +112,9 @@ private String serverName(int counter) {
@AfterClass
public void tearDown() {
for (Map.Entry<String, SegmentsServerMock> fakeServerEntry :
_serverMap.entrySet()) {
- fakeServerEntry.getValue()._httpServer.stop(0);
+ SegmentsServerMock server = fakeServerEntry.getValue();
+ server.stop();
+ server._httpServer.stop(0);
Review comment:
Is it possible to make this call inside the stop method of
`SegmentsServerMock`, so that you don't have to explicitly call it everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
