richardstartin commented on issue #7499: URL: https://github.com/apache/pinot/issues/7499#issuecomment-931041329
@ddcprg that would be awesome! As part of the effort, I would suggest building some unit testing around `DateTimeFunctions` to be sure there aren't any regressions. There is a blog post from the author of both libraries on performing the migration (from 2014) [here](https://blog.joda.org/2014/11/converting-from-joda-time-to-javatime.html). Don't miss the comment here: > One more "odds and ends" which is important to be aware of: > > the Joda DateTimeFormat (http://www.joda.org/joda-time/apidocs/org/joda/time/format/DateTimeFormat.html) uses "Y" for "year of era", and "y" for "year". The Java 8 DateTimeFormatter (https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html) uses "Y" for "week based year", and "y" for "year of era". If you're currently using a Joda DateTimeFormat object with "Y" as part of the pattern, this may introduce an off-by-one error (https://stackoverflow.com/questions/26431882/difference-between-year-of-era-and-week-based-year) if you change it to a Java 8 DateTimeFormatter without also replacing "Y" with "y" in the pattern string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
