richardstartin opened a new pull request #7530: URL: https://github.com/apache/pinot/pull/7530
## Description This uses better APIs from RoaringBitmap to speed up scans by around 25%: At 67f5617f2c7a09b44b448bbedb610229f759d336 (the addition of the benchmark) we have: ``` Benchmark (_bitmapQuantile) (_distribution) (_numDocs) (_seed) (_thresholdQuantile) Mode Cnt Score Error Units BenchmarkScanDocIdIterators.benchmarkSVLong 1 UNIFORM(0,10000000) 10000000 42 1 avgt 5 19.856 ± 0.839 ms/op BenchmarkScanDocIdIterators.benchmarkSVLong 1 UNIFORM(0,10000000) 10000000 42 2 avgt 5 20.061 ± 1.085 ms/op BenchmarkScanDocIdIterators.benchmarkSVLong 2 UNIFORM(0,10000000) 10000000 42 1 avgt 5 41.006 ± 1.170 ms/op BenchmarkScanDocIdIterators.benchmarkSVLong 2 UNIFORM(0,10000000) 10000000 42 2 avgt 5 34.342 ± 0.271 ms/o ``` At 8a0116404b54c528131dfc6b1be6157d48317982 (the improvement) we have: ``` Benchmark (_bitmapQuantile) (_distribution) (_numDocs) (_seed) (_thresholdQuantile) Mode Cnt Score Error Units BenchmarkScanDocIdIterators.benchmarkSVLong 1 UNIFORM(0,10000000) 10000000 42 1 avgt 5 15.022 ± 1.026 ms/op BenchmarkScanDocIdIterators.benchmarkSVLong 1 UNIFORM(0,10000000) 10000000 42 2 avgt 5 14.576 ± 1.762 ms/op BenchmarkScanDocIdIterators.benchmarkSVLong 2 UNIFORM(0,10000000) 10000000 42 1 avgt 5 35.679 ± 1.913 ms/op BenchmarkScanDocIdIterators.benchmarkSVLong 2 UNIFORM(0,10000000) 10000000 42 2 avgt 5 25.985 ± 0.547 ms/op ``` Note that there is an aspect of space time tradeoff here, in that we allocate a one kilobyte buffer per column scan, but this is negligible compared to materialisation of a bitmap. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
