richardstartin opened a new pull request #7537: URL: https://github.com/apache/pinot/pull/7537
## Description Fix #7534. There were 2 issues here 1. We were parsing date time e.g. 20211007 as a number of milliseconds, this just happened to create a valid number of milliseconds sometimes! 2. There isn't enough information to get a number of milliseconds in UTC. We don't know which timezone the simple date is in, but also don't know that there _isn't_ a timezone in the format string either, so the second change ensures that we don't test within a day of the minimum or maximum allowed number of milliseconds. This has no functional impact, it only relates to interval validation and Pinot wasn't live in 1971, I don't want to make a prediction about 2071. I added a couple of tests to fix the seed for degenerate cases. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
