This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c36d2b9 Cleanup sys out (#7547)
c36d2b9 is described below
commit c36d2b975041e08656598d69e3984bd9b3bb0c81
Author: Rong Rong <[email protected]>
AuthorDate: Fri Oct 8 13:39:23 2021 -0700
Cleanup sys out (#7547)
---
.../request/BrokerRequestSerializationTest.java | 38 ----------------------
.../pinot/request/BrokerResponseNativeTest.java | 2 --
.../org/apache/pinot/core/util/CrcUtilsTest.java | 3 --
...erSegmentResultTableSingleValueQueriesTest.java | 1 -
.../queries/SegmentWithNullValueVectorTest.java | 1 -
.../tests/JsonPathClusterIntegrationTest.java | 1 -
.../MergeRollupMinionClusterIntegrationTest.java | 1 -
.../tests/OfflineClusterIntegrationTest.java | 1 -
.../segment/local/segment/creator/BlocksTest.java | 1 -
.../FixedByteWidthRowColDataFileReaderTest.java | 2 --
...FixedByteWidthRowColForwardIndexWriterTest.java | 2 --
.../java/org/apache/pinot/tools/SpeedTest.java | 2 --
12 files changed, 55 deletions(-)
diff --git
a/pinot-common/src/test/java/org/apache/pinot/request/BrokerRequestSerializationTest.java
b/pinot-common/src/test/java/org/apache/pinot/request/BrokerRequestSerializationTest.java
index d6ca537..0917541 100644
---
a/pinot-common/src/test/java/org/apache/pinot/request/BrokerRequestSerializationTest.java
+++
b/pinot-common/src/test/java/org/apache/pinot/request/BrokerRequestSerializationTest.java
@@ -115,25 +115,6 @@ public class BrokerRequestSerializationTest {
TSerializer compactSerializer = new TSerializer(new
TCompactProtocol.Factory());
normalSerializer.serialize(req);
compactSerializer.serialize(req);
-
-// int numRequests = 100000;
-// TimerContext t = MetricsHelper.startTimer();
-// TSerializer serializer = new TSerializer(new TCompactProtocol.Factory());
-// //TSerializer serializer = new TSerializer();
-// //Compact : Size 183 , Serialization Latency : 0.03361ms
-// // Normal : Size 385 , Serialization Latency : 0.01144ms
-//
-// for (int i = 0; i < numRequests; i++) {
-// try {
-// serializer.serialize(req);
-// //System.out.println(s3.length);
-// //break;
-// } catch (TException e) {
-// e.printStackTrace();
-// }
-// }
-// t.stop();
-// System.out.println("Latency is :" + (t.getLatencyMs() / (float)
numRequests));
}
@Test
@@ -255,24 +236,5 @@ public class BrokerRequestSerializationTest {
TSerializer compactSerializer = new TSerializer(new
TCompactProtocol.Factory());
normalSerializer.serialize(req);
compactSerializer.serialize(req);
-
-// int numRequests = 100000;
-// TimerContext t = MetricsHelper.startTimer();
-// TSerializer serializer = new TSerializer(new TCompactProtocol.Factory());
-// //TSerializer serializer = new TSerializer();
-// //Compact : Size 183 , Serialization Latency : 0.03361ms
-// // Normal : Size 385 , Serialization Latency : 0.01144ms
-//
-// for (int i = 0; i < numRequests; i++) {
-// try {
-// serializer.serialize(req);
-// //System.out.println(s3.length);
-// //break;
-// } catch (TException e) {
-// e.printStackTrace();
-// }
-// }
-// t.stop();
-// System.out.println("Latency is :" + (t.getLatencyMs() / (float)
numRequests));
}
}
diff --git
a/pinot-common/src/test/java/org/apache/pinot/request/BrokerResponseNativeTest.java
b/pinot-common/src/test/java/org/apache/pinot/request/BrokerResponseNativeTest.java
index 1b4946f..74614f7 100644
---
a/pinot-common/src/test/java/org/apache/pinot/request/BrokerResponseNativeTest.java
+++
b/pinot-common/src/test/java/org/apache/pinot/request/BrokerResponseNativeTest.java
@@ -60,13 +60,11 @@ public class BrokerResponseNativeTest {
QueryProcessingException processingException = new
QueryProcessingException(400, errorMsgStr);
expected.addToExceptions(processingException);
String brokerString = expected.toJsonString();
-// System.out.println(brokerString);
BrokerResponseNative newBrokerResponse =
BrokerResponseNative.fromJsonString(brokerString);
Assert.assertEquals(newBrokerResponse.getProcessingExceptions().get(0).getErrorCode(),
QueryException.BROKER_RESOURCE_MISSING_ERROR.getErrorCode());
Assert.assertEquals(newBrokerResponse.getProcessingExceptions().get(0).getMessage(),
QueryException.BROKER_RESOURCE_MISSING_ERROR.getMessage());
-// System.out.println(newBrokerResponse.getProcessingExceptions().get(1));
Assert.assertEquals(newBrokerResponse.getProcessingExceptions().get(1).getErrorCode(),
400);
Assert.assertEquals(newBrokerResponse.getProcessingExceptions().get(1).getMessage(),
errorMsgStr);
}
diff --git
a/pinot-core/src/test/java/org/apache/pinot/core/util/CrcUtilsTest.java
b/pinot-core/src/test/java/org/apache/pinot/core/util/CrcUtilsTest.java
index bc12682..e4cf1bd 100644
--- a/pinot-core/src/test/java/org/apache/pinot/core/util/CrcUtilsTest.java
+++ b/pinot-core/src/test/java/org/apache/pinot/core/util/CrcUtilsTest.java
@@ -69,9 +69,6 @@ public class CrcUtilsTest {
final IndexSegment segment = ImmutableSegmentLoader.load(new
File(makeSegmentAndReturnPath()), ReadMode.mmap);
final SegmentMetadata m = segment.getSegmentMetadata();
-// System.out.println(m.getCrc());
-// System.out.println(m.getIndexCreationTime());
-
FileUtils.deleteQuietly(INDEX_DIR);
}
diff --git
a/pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentResultTableSingleValueQueriesTest.java
b/pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentResultTableSingleValueQueriesTest.java
index 9c2b100..6659daf 100644
---
a/pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentResultTableSingleValueQueriesTest.java
+++
b/pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentResultTableSingleValueQueriesTest.java
@@ -494,7 +494,6 @@ public class InterSegmentResultTableSingleValueQueriesTest
extends BaseSingleVal
// 4. test aggregation-only query with filter with SQL exec and response
format
brokerResponse = getBrokerResponseForSqlQuery(query + filter);
- System.out.println(query + getFilter());
QueriesTestUtils.testInterSegmentResultTable(brokerResponse, 51796L,
193884L, 103592L, 120000L, expectedRows,
expectedResultsSize, dataSchema);
diff --git
a/pinot-core/src/test/java/org/apache/pinot/queries/SegmentWithNullValueVectorTest.java
b/pinot-core/src/test/java/org/apache/pinot/queries/SegmentWithNullValueVectorTest.java
index 0a13434..e9f2cb0 100644
---
a/pinot-core/src/test/java/org/apache/pinot/queries/SegmentWithNullValueVectorTest.java
+++
b/pinot-core/src/test/java/org/apache/pinot/queries/SegmentWithNullValueVectorTest.java
@@ -236,7 +236,6 @@ public class SegmentWithNullValueVectorTest {
for (FieldSpec fieldSpec : _schema.getAllFieldSpecs()) {
NullValueVectorReader nullValueVector =
_segment.getDataSource(fieldSpec.getName()).getNullValueVector();
- System.out.println("field = " + fieldSpec.getName());
Assert.assertNotNull(nullValueVector);
nullValueVectorReaderMap.put(fieldSpec.getName(), nullValueVector);
}
diff --git
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/JsonPathClusterIntegrationTest.java
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/JsonPathClusterIntegrationTest.java
index 03b268b..9121bb2 100644
---
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/JsonPathClusterIntegrationTest.java
+++
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/JsonPathClusterIntegrationTest.java
@@ -298,7 +298,6 @@ public class JsonPathClusterIntegrationTest extends
BaseClusterIntegrationTest {
pqlQuery = "Select " + COMPLEX_MAP_STR_K3_FIELD_NAME + " from " +
DEFAULT_TABLE_NAME;
pinotResponse = postQuery(pqlQuery);
selectionResults = (ArrayNode)
pinotResponse.get("selectionResults").get("results");
- System.out.println("selectionResults = " + selectionResults);
Assert.assertNotNull(selectionResults);
Assert.assertFalse(selectionResults.isEmpty());
diff --git
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MergeRollupMinionClusterIntegrationTest.java
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MergeRollupMinionClusterIntegrationTest.java
index d98dc7e..d86e00a 100644
---
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MergeRollupMinionClusterIntegrationTest.java
+++
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MergeRollupMinionClusterIntegrationTest.java
@@ -556,7 +556,6 @@ public class MergeRollupMinionClusterIntegrationTest
extends BaseClusterIntegrat
TestUtils.waitForCondition(input -> {
// Check if the segment lineage is cleaned up
if (SegmentLineageAccessHelper.getSegmentLineage(_propertyStore,
tableNameWithType) != null) {
- System.out.println("Not deleted..");
return false;
}
// Check if the task metadata is cleaned up
diff --git
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
index cd707d2..933257e 100644
---
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
+++
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
@@ -385,7 +385,6 @@ public class OfflineClusterIntegrationTest extends
BaseClusterIntegrationTestSet
.uploadSegment(uploadSegmentHttpURI, segmentTarFile.getName(),
segmentTarFile, null, parameters,
FileUploadDownloadClient.DEFAULT_SOCKET_TIMEOUT_MS);
assertEquals(response.getStatusCode(), HttpStatus.SC_OK);
- System.out.println(response.getResponse());
List<SegmentZKMetadata> segmentsZKMetadata =
_helixResourceManager.getSegmentsZKMetadata(offlineTableName);
assertEquals(segmentsZKMetadata.size(), 1);
diff --git
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/BlocksTest.java
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/BlocksTest.java
index f684960..9f65b29 100644
---
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/BlocksTest.java
+++
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/BlocksTest.java
@@ -54,7 +54,6 @@ public class BlocksTest {
FileUtils.deleteQuietly(INDEX_DIR);
}
-// System.out.println(INDEX_DIR.getAbsolutePath());
final SegmentIndexCreationDriver driver =
SegmentCreationDriverFactory.get(null);
final SegmentGeneratorConfig config = SegmentTestUtils
diff --git
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/reader/FixedByteWidthRowColDataFileReaderTest.java
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/reader/FixedByteWidthRowColDataFileReaderTest.java
index 5897c57..c069619 100644
---
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/reader/FixedByteWidthRowColDataFileReaderTest.java
+++
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/reader/FixedByteWidthRowColDataFileReaderTest.java
@@ -50,7 +50,6 @@ public class FixedByteWidthRowColDataFileReaderTest {
dos.flush();
dos.close();
RandomAccessFile raf = new RandomAccessFile(f, "rw");
-// System.out.println("file size: " + raf.getChannel().size());
raf.close();
try (FixedByteSingleValueMultiColReader heapReader = new
FixedByteSingleValueMultiColReader(
@@ -87,7 +86,6 @@ public class FixedByteWidthRowColDataFileReaderTest {
dos.flush();
dos.close();
RandomAccessFile raf = new RandomAccessFile(f, "rw");
-// System.out.println("file size: " + raf.getChannel().size());
raf.close();
try (FixedByteSingleValueMultiColReader heapReader = new
FixedByteSingleValueMultiColReader(
diff --git
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/writer/FixedByteWidthRowColForwardIndexWriterTest.java
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/writer/FixedByteWidthRowColForwardIndexWriterTest.java
index c700521..16bfa2f 100644
---
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/writer/FixedByteWidthRowColForwardIndexWriterTest.java
+++
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/writer/FixedByteWidthRowColForwardIndexWriterTest.java
@@ -187,7 +187,6 @@ public class FixedByteWidthRowColForwardIndexWriterTest {
int cols = 1;
String testString1 = new String(bytes1);
String testString2 = new String(bytes2);
-// System.out.println(Arrays.toString(bytes2));
int stringColumnMaxLength = Math.max(testString1.getBytes().length,
testString2.getBytes().length);
int[] columnSizes = new int[]{stringColumnMaxLength};
FixedByteSingleValueMultiColWriter writer = new
FixedByteSingleValueMultiColWriter(file, rows, cols, columnSizes);
@@ -233,7 +232,6 @@ public class FixedByteWidthRowColForwardIndexWriterTest {
int cols = 1;
String testString1 = new String(bytes1);
String testString2 = new String(bytes2);
-// System.out.println(Arrays.toString(bytes2));
int stringColumnMaxLength = Math.max(testString1.getBytes().length,
testString2.getBytes().length);
int[] columnSizes = new int[]{stringColumnMaxLength};
FixedByteSingleValueMultiColWriter writer = new
FixedByteSingleValueMultiColWriter(file, rows, cols, columnSizes);
diff --git a/pinot-tools/src/main/java/org/apache/pinot/tools/SpeedTest.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/SpeedTest.java
index 68a903c..432cdea 100644
--- a/pinot-tools/src/main/java/org/apache/pinot/tools/SpeedTest.java
+++ b/pinot-tools/src/main/java/org/apache/pinot/tools/SpeedTest.java
@@ -71,8 +71,6 @@ public class SpeedTest {
ind = ind + 1;
}
}
- //System.out.println(Arrays.toString(heapStorage));
- //System.out.println(Arrays.toString(readIndices));
}
private long directMemory() {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
