walterddr opened a new pull request #7567: URL: https://github.com/apache/pinot/pull/7567
## Description This allows TableConfigBuilder init from TableConfig. ## Goal Goal of this PR is having an easy way to clone a tableConfig, modify some subfields and construct a new one tableConfig. Currently there's no easy way to do so. ## Alternative solutions solution 1 is to go with the Builder path (this PR) - Pro: it explicitly ask the user to copy the tableConfig because it doesn't expose setter directly. - Con: there's deep-copy overhead; there's maintenance cost in TableConfigBuilder when adding/changing configs solution 2 is to directly add a field setter - Pro: easy and straightforward - Con: doesn't prevent accident change to tableConfig without a copy; Since config change usually doesn't affect performance-critical path I prefer solution1 because of its auto safety against accidental config changes. but open to solution2 or other suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
