Jackie-Jiang commented on a change in pull request #7556:
URL: https://github.com/apache/pinot/pull/7556#discussion_r727502324
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableInstances.java
##########
@@ -68,7 +69,8 @@ public String getTableInstances(
ObjectNode e = JsonUtils.newObjectNode();
e.put("tableType", "offline");
ArrayNode a = JsonUtils.newArrayNode();
- for (String ins :
_pinotHelixResourceManager.getBrokerInstancesForTable(tableName,
TableType.OFFLINE)) {
+ for (String ins : _pinotHelixResourceManager
+
.getLiveBrokersForTable(TableNameBuilder.OFFLINE.tableNameWithType(tableName)))
{
Review comment:
This will make the broker and server behavior inconsistent (currently
both of them are tag based), and change the behavior of this API
##########
File path: pinot-controller/pom.xml
##########
@@ -197,6 +197,10 @@
<groupId>org.quartz-scheduler</groupId>
<artifactId>quartz</artifactId>
</dependency>
+ <dependency>
Review comment:
Pinot-controller should not include client module. We should implement
it separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
