richardstartin commented on a change in pull request #7595:
URL: https://github.com/apache/pinot/pull/7595#discussion_r732254388
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkSVForwardIndexWriter.java
##########
@@ -95,6 +96,62 @@ public void putBytes(byte[] value) {
_chunkBuffer.put(value);
_chunkDataOffSet += value.length;
+ writeChunkIfNecessary();
+ }
+
+ // Note: some duplication is tolerated between these overloads for the sake
of memory efficiency
Review comment:
@kishoreg I moved the construction of the MV `STRING`/`BYTES` into here
to avoid excessive allocation and multiple passes.
This points to how to make this class a bit more memory efficient in general
- we only need to guarantee fixed capacity for the offsets, which are fixed
width, and we can write the variable length body page by page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
