npawar commented on pull request #7605: URL: https://github.com/apache/pinot/pull/7605#issuecomment-947871028
There's some cases where this will not work. Consider a case where all segments are CONSUMING, and there's no segment with status DONE yet. `segmentNames.isEmpty` will be true, `skipGenerate` will be false, and we'll progress the watermark. I think a safer way to do this would be, if there's no segmentNames, calculate the next window, and check if there's completed segments in that window. Only then progress the window, because then we're certain that the next window has completed segmets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
