atris commented on a change in pull request #7566:
URL: https://github.com/apache/pinot/pull/7566#discussion_r733480880
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
##########
@@ -161,6 +161,97 @@ public static FunctionContext
getFunction(FunctionCallAstNode astNode) {
}
}
+ /**
+ * Converts the given {@link ExpressionContext} into a {@link FilterContext}.
+ * <p>NOTE: Currently the query engine only accepts string literals as the
right-hand side of the predicate, so we
+ * always convert the right-hand side expressions into strings.
+ */
+ public static FilterContext getFilter(ExpressionContext expressionContext) {
Review comment:
As discussed offline, letting the status quo be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
