atris commented on pull request #7563:
URL: https://github.com/apache/pinot/pull/7563#issuecomment-948541885


   > With the current approach of pre-computing the filter operator, we still 
need to create the predicate evaluator twice with star-tree. Alternatively, we 
can pre-compute a map from `Predicate` to `PredicateEvaluator`, and use it to 
decide whether metadata/dictionary/star-tree based operator can be applied. 
This map can also be passed to the `FilterPlanNode` to accelerate creation of 
the `FilterOperator`
   
   Thanks for taking a look. I have added a map for acceleration of 
PredicateEvaluator construction in StarTreeUtils.
   
   FYI the failing test on CI is unrelated to the PR -- it is a Zookeeper 
timeout.
   
   Please review and let me know your thoughts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to