jackjlli commented on a change in pull request #7644:
URL: https://github.com/apache/pinot/pull/7644#discussion_r737667929
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -1481,6 +1492,9 @@ private static String getActualColumnName(String
rawTableName, String columnName
return actualAlias;
}
}
+ if (!throwExceptionForInvalidColumn) {
+ return columnName;
Review comment:
Can we emit a table level metric here to indicate that an invalid column
is used?
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
##########
@@ -464,11 +466,9 @@ private CommonConstants() {
public static class Realtime {
public enum Status {
// Means the segment is in CONSUMING state.
- IN_PROGRESS,
- // Means the segment is in ONLINE state (segment completed consuming
and has been saved in
+ IN_PROGRESS, // Means the segment is in ONLINE state (segment
completed consuming and has been saved in
Review comment:
Revert these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
