kkrugler commented on a change in pull request #7646:
URL: https://github.com/apache/pinot/pull/7646#discussion_r737688557



##########
File path: 
pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentCreationMapper.java
##########
@@ -165,7 +165,8 @@ public void setup(Context context)
             new NormalizedDateSegmentNameGenerator(_rawTableName, 
_jobConf.get(JobConfigConstants.SEGMENT_NAME_PREFIX),
                 _jobConf.getBoolean(JobConfigConstants.EXCLUDE_SEQUENCE_ID, 
false),
                 
IngestionConfigUtils.getBatchSegmentIngestionType(_tableConfig),
-                
IngestionConfigUtils.getBatchSegmentIngestionFrequency(_tableConfig), 
dateTimeFormatSpec);
+                
IngestionConfigUtils.getBatchSegmentIngestionFrequency(_tableConfig), 
dateTimeFormatSpec,
+                _jobConf.get(JobConfigConstants.SEGMENT_NAME_POSTFIX));

Review comment:
       Would this same change need to be made in `v0_deprecated/pinot-spark`, 
`pinot-batch-ingestion-common`, the local support, and other places where `new 
NormalizedDateSegmentNameGenerator()` is called?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to