klsince commented on a change in pull request #7645:
URL: https://github.com/apache/pinot/pull/7645#discussion_r742182416
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java
##########
@@ -286,6 +288,14 @@ public void setCustomProperties(Map<String, String>
properties) {
_customProperties.putAll(properties);
}
+ private void setDateTimeFormatSpec(DateTimeFormatSpec formatSpec) {
+ _dateTimeFormatSpec = formatSpec;
Review comment:
I see `_segmentTimeUnit` has its own setter and getter, and it's only
used for EPOCH time format.
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java
##########
@@ -286,6 +288,14 @@ public void setCustomProperties(Map<String, String>
properties) {
_customProperties.putAll(properties);
}
+ private void setDateTimeFormatSpec(DateTimeFormatSpec formatSpec) {
+ _dateTimeFormatSpec = formatSpec;
Review comment:
nvm, as we make setDateTimeFormatSpec public, setting the type and unit
consistently is necessary.
##########
File path:
pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfigTest.java
##########
@@ -75,14 +75,14 @@ public void testSimpleDateFormat() {
assertEquals(segmentGeneratorConfig.getTimeColumnName(), "Date");
assertEquals(segmentGeneratorConfig.getTimeColumnType(),
SegmentGeneratorConfig.TimeColumnType.SIMPLE_DATE);
assertNull(segmentGeneratorConfig.getSegmentTimeUnit());
- assertEquals(segmentGeneratorConfig.getSimpleDateFormat(), "yyyyMMdd");
+
assertEquals(segmentGeneratorConfig.getDateTimeFormatSpec().getSDFPattern(),
"yyyyMMdd");
Review comment:
the _simpleDateFormat var is simply removed from segmentGeneratorConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
