mcvsubbu commented on a change in pull request #7743:
URL: https://github.com/apache/pinot/pull/7743#discussion_r747886490
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -872,8 +872,14 @@ public void ensureAllPartitionsConsuming(TableConfig
tableConfig, PartitionLevel
if (idealState.isEnabled()) {
List<PartitionGroupConsumptionStatus>
currentPartitionGroupConsumptionStatusList =
getPartitionGroupConsumptionStatusList(idealState, streamConfig);
+
+ // Read the smallest offset when a new partition is detected
+ OffsetCriteria originalOffsetCriteria =
streamConfig.getOffsetCriteria();
+
streamConfig.setOffsetCriteria(OffsetCriteria.SMALLEST_OFFSET_CRITERIA);
Review comment:
I think we can use the local private method to get the earliest offset.
These should be very rare, so an extra call to the stream should not matter.
I would prefer that we not change the table config in any way in case
someone adds some code in this flow to pick up the table config and make some
decision based on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
