Jackie-Jiang commented on a change in pull request #7774:
URL: https://github.com/apache/pinot/pull/7774#discussion_r751498411
##########
File path:
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotDriver.java
##########
@@ -68,6 +69,9 @@ public Connection connect(String url, Properties info)
PinotClientTransport pinotClientTransport = factory.buildTransport();
String controllerUrl = DriverUtils.getControllerFromURL(url);
String tenant = info.getProperty(INFO_TENANT, DEFAULT_TENANT);
+
+ if(!headers.isEmpty())
+ new PinotConnection(controllerUrl, pinotClientTransport, tenant, new
PinotControllerTransport(headers));
Review comment:
Since the headers are already set into the client factory (line 66), why
do we need to add it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
