jadami10 opened a new pull request #7803:
URL: https://github.com/apache/pinot/pull/7803


   ## Description
   <!-- Add a description of your PR here.
   A good description should include pointers to an issue or design document, 
etc.
   -->
   This allows the controller to handle the case where the externalview is 
missing a segment that is in the ideal state. I'm not sure yet how this happens 
in our cluster, but it keeps the whole controller table UI from loading which 
makes it hard to even identify the missing segment. There's likely room to 
either
   1) improve the status from "bad" to something like "missing"
   2) find the bug that's leading to segments missing in the external view
   
   I want to say this is related to #7779, but we've seen it in clusters 
without tiered storage as well.
   
   To test, locally I ran the realtime quickstart, deleted the segment from 
externalview, and opened the page in the UI. The segment now reports as BAD
   
![image](https://user-images.githubusercontent.com/4760722/142699644-352a53a6-a58e-453f-8550-cf0c12abdf5b.png)
   and has no server
   
![image](https://user-images.githubusercontent.com/4760722/142699666-e3afeb47-44e0-4dd4-8060-72b747e71235.png)
   
   ## Upgrade Notes
   Does this PR prevent a zero down-time upgrade? (Assume upgrade order: 
Controller, Broker, Server, Minion)
   * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete 
the section below on Release Notes)
   
   Does this PR fix a zero-downtime upgrade introduced earlier?
   * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and 
complete the section below on Release Notes)
   
   Does this PR otherwise need attention when creating release notes? Things to 
consider:
   - New configuration options
   - Deprecation of configurations
   - Signature changes to public methods/interfaces
   - New plugins added or old plugins removed
   * [ ] Yes (Please label this PR as **<code>release-notes</code>** and 
complete the section on Release Notes)
   
   Nothing of note that needs attention
   ## Release Notes
   <!-- If you have tagged this as either backward-incompat or release-notes,
   you MUST add text here that you would like to see appear in release notes of 
the
   next release. -->
   
   <!-- If you have a series of commits adding or enabling a feature, then
   add this section only in final commit that marks the feature completed.
   Refer to earlier release notes to see examples of text.
   -->
   ## Documentation
   <!-- If you have introduced a new feature or configuration, please add it to 
the documentation as well.
   See 
https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to