siddharthteotia commented on a change in pull request #7823:
URL: https://github.com/apache/pinot/pull/7823#discussion_r755762444
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -459,7 +459,13 @@ private BrokerResponseNative handleSQLRequest(long
requestId, String query, Json
if (offlineBrokerRequest == null && realtimeBrokerRequest == null) {
LOGGER.info("No server found for request {}: {}", requestId, query);
_brokerMetrics.addMeteredTableValue(rawTableName,
BrokerMeter.NO_SERVER_FOUND_EXCEPTIONS, 1);
- return BrokerResponseNative.EMPTY_RESULT;
+ BrokerResponseNative brokerResponse = BrokerResponseNative.EMPTY_RESULT;
+ if (numUnavailableSegments > 0) {
Review comment:
I think the intention of the PR
https://github.com/apache/pinot/pull/7397 was to always add this exception to
BrokerResponse if numUnavailableSegments is > 0 and this case was missed ?
So may be we just do this once by moving the code at line 512 to proper
place that covers all scenarios unconditionally ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
