richardstartin commented on pull request #7828: URL: https://github.com/apache/pinot/pull/7828#issuecomment-978891304
> I actually considered that, and decided to go with the snapshot approach because we want to optimize the query runtime method as much as possible I don’t think this likely to be an optimisation unless the removeAll call is made frequently and the number of empty segments is large. I think when an optimisation makes the code much harder to read we need 4 bits of data: 1. **evidence that there is a problem** - e.g. wall time thresholded tracing events around EmptySegmentPruner.prune, or a sampling profiler reporting lots of samples in this method 2. **evidence that the thing being optimised solves the problem** - assuming we have data that there is a problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
