mayankshriv commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r758704062
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##########
@@ -120,6 +121,17 @@ public int getNumDocs() {
return intValues;
}
+ /**
+ * Get the int values for a single-valued column.
+ *
+ * @param column Column name
+ * @param evaluator JSON path evaluator
+ * @param buffer values to fill
+ */
+ public void fillValues(String column, JsonPathEvaluator evaluator, int[]
buffer) {
Review comment:
Yeah I see your point about the rule of 3. I think I put the comment in
a less effective place, since this is not an interface implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
