Jackie-Jiang commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r760502909
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/common/Operator.java
##########
@@ -46,6 +47,12 @@
*/
String getOperatorName();
+ /** @return List of {@link Operator}s that this operator depends upon. */
+ List<Operator> getChildOperators();
+
+ /** @return Description of this operator for Explain Plan */
+ String toExplainString();
Review comment:
Let's add something like `when it returns null, the operator won't be
included in the explain plan tree`
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/DocIdSetOperator.java
##########
@@ -34,6 +37,7 @@
*/
public class DocIdSetOperator extends BaseOperator<DocIdSetBlock> {
private static final String OPERATOR_NAME = "DocIdSetOperator";
+ private static final String EXPLAIN_NAME = null;
Review comment:
Sure, I don't see this as a blocker, but I do feel this level is useful
to understand the query execution layers, so suggest including it in the
explain tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
