jackjlli commented on a change in pull request #7878:
URL: https://github.com/apache/pinot/pull/7878#discussion_r764452526



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -617,12 +622,21 @@ public String getCrypterClassNameFromTableConfig(String 
tableNameWithType) {
         }
       }
     }
+    return retainLiveSegments(tableNameWithType, selectedSegments);
+  }
+
+  /**
+   * Given the list of segment names, retains live segments which are queried.
+   * @param tableNameWithType table name with type
+   * @param segments list of input segment names
+   */
+  private List<String> retainLiveSegments(String tableNameWithType, 
List<String> segments) {

Review comment:
       Renamed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to