richardstartin commented on a change in pull request #7876:
URL: https://github.com/apache/pinot/pull/7876#discussion_r765059886
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/creator/JsonIndexCreator.java
##########
@@ -29,7 +29,39 @@
char KEY_VALUE_SEPARATOR = '\0';
/**
- * Adds the next json value.
+ * To be invoked once before each physical JSON document when streaming JSON
into the index
+ * @param numFlattenedDocs the number of flattened documents to be streamed
into the index
+ */
+ default void startDocument(int numFlattenedDocs) {
+ }
+
+ /**
+ * To be invoked after each physical JSON document when streaming JSON into
the index.
+ */
+ default void endDocument() {
+ }
+
+ /**
+ * To be invoked once before each nested (logical) JSON document when
streaming JSON into the index
Review comment:
I'm inclined to agree on this point and think I can achieve the same
effect with a different interface. I will address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
