Jackie-Jiang commented on a change in pull request #7839:
URL: https://github.com/apache/pinot/pull/7839#discussion_r765334733



##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java
##########
@@ -35,9 +35,16 @@
 
   void addException(ProcessingException processingException);
 
+  void addException(int exceptionCode, String exceptionMsg);
+
   Map<Integer, String> getExceptions();
 
-  byte[] toBytes()
+  default byte[] toBytes()
+      throws IOException {
+    return toBytes(false);
+  }
+
+  byte[] toBytes(boolean isStrippingMetadata)

Review comment:
       I'm thinking of replicating the `DataTable` object but not the content 
inside. For the `MetadataOnlyDataTable`, instantiate a new data table with just 
the `_metadata`; for the `DataOnlyDataTable`, instantiate a new data table with 
everything except for the `_metadata`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to