kishansairam9 edited a comment on pull request #7877: URL: https://github.com/apache/pinot/pull/7877#issuecomment-990395612
By looking at code related to failing tests, I felt that it might be better to change exception type rather than tests. I say so because test failures weren't caused by direct invocation of modified functions but as part of chained calls. This might lead to cascading effect on number of changes required in tests given that `planExecution` could be one of primitive functions. That being said, my opinion is based on very limited understanding of repo. In case it would be preferred to change tests itself, it would be great if you could leave pointers on those which would require modification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
