Jackie-Jiang commented on a change in pull request #7839:
URL: https://github.com/apache/pinot/pull/7839#discussion_r767460586
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/BaseDataTable.java
##########
@@ -250,6 +250,18 @@ public ByteArray getBytes(int rowId, int colId) {
return strings;
}
+ @Override
+ public DataTable toMetadataOnlyDataTable() {
+ DataTable destDataTable = DataTableBuilder.getEmptyDataTable();
+ destDataTable.getMetadata().putAll(this.getMetadata());
+ if (!this.getExceptions().isEmpty()) {
Review comment:
This method needs to be implemented in each individual data table
implementation as in V2 the exception is stored in `_metadata`, but in V3 it is
stored as a separate map. We don't want to add the exception again if it is
already stored in `_metadata`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
