Jackie-Jiang commented on a change in pull request #7896:
URL: https://github.com/apache/pinot/pull/7896#discussion_r768256982
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
##########
@@ -901,9 +901,8 @@ protected void hold() {
}
@Override
- protected boolean buildSegmentAndReplace() {
+ protected void buildSegmentAndReplace() throws Exception {
Review comment:
(code format) same
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -935,14 +939,9 @@ protected boolean commitSegment(String controllerVipUrl,
boolean isSplitCommit)
return segmentCommitter.commit(_segmentBuildDescriptor);
}
- protected boolean buildSegmentAndReplace() {
+ protected void buildSegmentAndReplace() throws Exception {
SegmentBuildDescriptor descriptor = buildSegmentInternal(false);
Review comment:
(major) when segment build failed, it will return `null` descriptor
instead of throwing exception. In order to make it work, we need to change
`buildSegmentInternal()` to throw exception as well
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -935,14 +939,9 @@ protected boolean commitSegment(String controllerVipUrl,
boolean isSplitCommit)
return segmentCommitter.commit(_segmentBuildDescriptor);
}
- protected boolean buildSegmentAndReplace() {
+ protected void buildSegmentAndReplace() throws Exception {
Review comment:
(code format) Please setup the code format following:
https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#setup-ide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
