Jackie-Jiang commented on a change in pull request #7909:
URL: https://github.com/apache/pinot/pull/7909#discussion_r771755679
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -744,6 +742,9 @@ protected void buildSegmentForCommit(long buildTimeLeaseMs)
{
}
_leaseExtender.addSegment(_segmentNameStr, buildTimeLeaseMs,
_currentOffset);
_segmentBuildDescriptor = buildSegmentInternal(true);
+ } catch (Exception e) {
Review comment:
This is actually changing the behavior because the exception is not
thrown out in the new code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
