richardstartin commented on a change in pull request #7927:
URL: https://github.com/apache/pinot/pull/7927#discussion_r771821729
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -401,16 +409,12 @@ protected boolean consumeLoop()
.fetchMessages(_currentOffset, null,
_partitionLevelStreamConfig.getFetchTimeoutMillis());
_endOfPartitionGroup = messageBatch.isEndOfPartitionGroup();
_consecutiveErrorCount = 0;
- } catch (TimeoutException e) {
- handleTransientStreamErrors(e);
- continue;
- } catch (TransientConsumerException e) {
- handleTransientStreamErrors(e);
- continue;
} catch (PermanentConsumerException e) {
_segmentLogger.warn("Permanent exception from stream when fetching
messages, stopping consumption", e);
throw e;
} catch (Exception e) {
+ // all exceptions but PermanentConsumerException are handled the same
way
+ // can be a TimeoutException or TransientConsumerException routinely
Review comment:
Collapsed identical catch blocks for the sake of the person reading the
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
