walterddr commented on a change in pull request #7921:
URL: https://github.com/apache/pinot/pull/7921#discussion_r771849153
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
##########
@@ -330,8 +333,8 @@ static void validateTaskConfigs(TableConfig tableConfig,
Schema schema) {
// TODO task specific validate logic should directly call to
PinotTaskGenerator API
if (taskTypeConfigName.equals(REALTIME_TO_OFFLINE_TASK_TYPE)) {
// check table is not upsert
- Preconditions.checkState(tableConfig.getUpsertMode() ==
UpsertConfig.Mode.NONE,
- "RealtimeToOfflineTask doesn't support upsert ingestion mode!");
+ Preconditions.checkState(tableConfig.getUpsertMode() ==
UpsertConfig.Mode.NONE || taskTypeConfig.containsKey(
Review comment:
just to make sure I understand this correctly. so the solution would be
to add a query_parameter to `TableConfigsRestletResource#addConfig` and
`#updateConfig`
- for example: `/tableConfigs/myTable?skipValidation=TASK,INGEST`
and then propagate these skipValidation parameter through the validation
utils ONLY when tableconfig is being modified? correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
