richardstartin commented on a change in pull request #7920:
URL: https://github.com/apache/pinot/pull/7920#discussion_r771899485
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/FixedByteChunkSVForwardIndexReader.java
##########
@@ -48,6 +52,179 @@ public ChunkReaderContext createContext() {
}
}
+ @Override
+ public void fillValues(int[] docIds, int length, int[] values,
ChunkReaderContext context) {
Review comment:
Last time I called a method which filled an out-parameter array
something like `readValues` I was asked to change it to `fillValues`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
