xiangfu0 commented on a change in pull request #7928:
URL: https://github.com/apache/pinot/pull/7928#discussion_r772720296
##########
File path: docker/images/pinot/docker-build.sh
##########
@@ -56,6 +56,13 @@ else
JAVA_VERSION=8
fi
-echo "Trying to build Pinot docker image from Git URL: [ ${PINOT_GIT_URL} ] on
branch: [ ${PINOT_BRANCH} ] and tag it as: [ ${DOCKER_TAG} ]. Kafka
Dependencies: [ ${KAFKA_VERSION} ]. Java Version: [ ${JAVA_VERSION} ]."
+if [[ "$#" -gt 5 ]]
+then
+ JDK_VERSION=$5
+else
+ JDK_VERSION=$JAVA_VERSION
+fi
+
+echo "Trying to build Pinot docker image from Git URL: [ ${PINOT_GIT_URL} ] on
branch: [ ${PINOT_BRANCH} ] and tag it as: [ ${DOCKER_TAG} ]. Kafka
Dependencies: [ ${KAFKA_VERSION} ]. Java Version: [ ${JAVA_VERSION} ]. JDK
Version: [ ${JDK_VERSION} ]."
-docker build --no-cache -t ${DOCKER_TAG} --build-arg
PINOT_BRANCH=${PINOT_BRANCH} --build-arg PINOT_GIT_URL=${PINOT_GIT_URL}
--build-arg KAFKA_VERSION=${KAFKA_VERSION} --build-arg
JAVA_VERSION=${JAVA_VERSION} -f Dockerfile .
+docker build --no-cache -t ${DOCKER_TAG} --build-arg
PINOT_BRANCH=${PINOT_BRANCH} --build-arg PINOT_GIT_URL=${PINOT_GIT_URL}
--build-arg KAFKA_VERSION=${KAFKA_VERSION} --build-arg
JAVA_VERSION=${JAVA_VERSION} --build-arg JDK_VERSION=${JDK_VERSION} -f
Dockerfile .
Review comment:
Can you also add an option for `${OPENJDK_IMAGE}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
